Skip to content

Conversation

@bsmth
Copy link
Member

@bsmth bsmth commented Feb 28, 2024

Similar to mdn/dom-examples#260, adding template workflows, formatting configs.

Also adds language to code blocks in accompanying docs files.

TODO

  • add CONTRIBUTING.md, link to it from README

@bsmth bsmth requested a review from pepelsbey February 28, 2024 10:17
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you :)

But if I’m nitpicking, I’d say that CODEOWNERS and .prettierignore files don’t have a final newline that’s required by the .editorconfig. It’s not going to cause any trouble, though :)

@bsmth
Copy link
Member Author

bsmth commented Mar 7, 2024

But if I’m nitpicking, I’d say that CODEOWNERS and .prettierignore files don’t have a final newline that’s required by the .editorconfig. It’s not going to cause any trouble, though :)

Good point, added in 15528b9

Thank you!

@bsmth bsmth merged commit eb01020 into mdn:main Mar 7, 2024
@bsmth bsmth deleted the template-docs branch March 7, 2024 15:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants